search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Update CMakeLists.txt: set minimum cmake version to 3.18 #611

Closed climbfuji closed 17 hours ago

climbfuji commented 1 week ago

All in the title. Resolves https://github.com/NCAR/ccpp-framework/issues/610

User interface changes?: No

Fixes: https://github.com/NCAR/ccpp-framework/issues/610

Testing: only CI testing needed

Related to https://github.com/NCAR/ccpp-physics/pull/1101

climbfuji commented 1 day ago

@climbfuji Can you direct this commit to the develop branch instead of the main branch please?

May I ask why? This is intended to go in asap instead of waiting for the lengthy process of validating the capgen changes. It's a simple fix needed for UFS (and other models will benefit from it). I can easily cherry-pick the commit and create a parallel PR for develop if you think that is helpful/more in line with the (not-yet-finalized) development workflow.

mkavulich commented 17 hours ago

@climbfuji at today's meeting we decided to go ahead and merge this PR as-is, but we'll need to have a discussion about the protocol for making commits directly to main at a future meeting.

climbfuji commented 16 hours ago

@climbfuji at today's meeting we decided to go ahead and merge this PR as-is, but we'll need to have a discussion about the protocol for making commits directly to main at a future meeting.

Technically speaking we should have tested this with the UFS (combine with their next PR), but ok. @DusanJovic-NOAA Can you update the ccpp-framework submodule pointer in your next PR, please? Or in any other PR that involves fv3atm that goes in next. Thanks very much.

Looking forward to the "merge to main" discussion. This is going to happen more often, because develop is de-facto dev-capgen at the moment (and will become dev-ncarsima or something like that in the future). Consolidated updates from NRL's internal develop branch will all come to main directly.