search

NCAR / ccpp-physics

GFS physics for CCPP
Other
56 stars 145 forks source link

On branch jm-pr-multiple-instances-of-ccpp-physics #1000

Open michalakes opened 1 year ago

michalakes commented 1 year ago 
Changes to add an instance index to CCPP physics

Changes to be committed: modified: physics/GFS_phys_time_vary.fv3.F90 modified: physics/GFS_phys_time_vary.fv3.meta modified: physics/h2ointerp.f90 modified: physics/mp_thompson.F90 modified: physics/mp_thompson.meta modified: physics/ozinterp.f90

climbfuji commented 3 months ago

@dustinswales @grantfirl We'll need to revive this PR and make sure it finds its way into the authoritative codebase. I'll work on updating it to the latest NCAR main code (a few conflicts to resolve).

climbfuji commented 3 months ago

@dustinswales @grantfirl I am going to revive this PR. How do you want me to proceed, since these changes are for NCAR main? Should I simply update the PR from NCAR main and resolve the conflicts? Are you going to bring this down to the ufs fork for testing? Thanks ...

grantfirl commented 3 months ago

@dustinswales I thought these changes were already incorporated into ufs/dev? Or was it just partial?

grantfirl commented 3 months ago

@dustinswales I thought these changes were already incorporated into ufs/dev? Or was it just partial?

OK, it looks like https://github.com/ufs-community/ccpp-physics/pull/75 and the followup https://github.com/ufs-community/ccpp-physics/pull/150 partially contained some of these changes, at least for ozone physics.

Since those were targeted at ufs-community, I'm thinking that it might be best to rebase this off of ufs/dev and target a PR there.

dustinswales commented 3 months ago

@grantfirl Correct. Only the ozone physics were updated to address Johns issues. To wrap this up we should to refactor the h2o photochemistry scheme identically to the ozone. Then the changes to mp_thompson and the GFS interstitials are trivial, we just need to move some things from module memory to interstitials OR define them with the instance dimension (I vote for the former). If this sounds good I can do the h2o changes, but probably not for a week at least.

climbfuji commented 3 months ago

Sounds great, thank you both. I can help with the remaining changes after Dustin is done with h2o.