search

NCAR / ccpp-physics

GFS physics for CCPP
Other
56 stars 144 forks source link

Major updated CSAW deep convective scheme and made the CSAWMG schemes pass RTs for intel and GNU #1063

Closed AnningCheng-NOAA closed 5 months ago

AnningCheng-NOAA commented 5 months ago

• Major updated CSAW deep convective scheme: considering sigma vertical veriantion and reduction on fluxes instead of tendency etc. • Regression tests are performed on the new version of CSAW for GNU and intel compilers Here is a EMail from Don describe the changes: On Thu, Oct 24, 2019 at 3:01 PM Donald Dazlich - NOAA Affiliate [donald.dazlich@noaa.gov](mailto:donald.dazlich@noaa.gov) wrote: Hi Moorthi, Anning, Dave and I have been using the GFS version of CS to redo our implementation of AW more completely and consistently. Now, you will find that the fix_form implemetation of the tendencies match up very closely with the traditional form. Also you will notice that it is the fluxes for each cloud type (and the downdraft) that are saved and the reduction is done on the fluxes, not the tendency computed from the flux divergence. Since sigma is a function of height the latter approach is incorrect. I’ve also dimensioned several cloud type variables nctp+1 - the nctp+1 slot has downdraft output. Another addition is the sorting of the lamdas after they are computed for all cloud types, then computing the sigma. This approach is detailed in a manuscript Dave is working on. Also, sigma is not applied to the inputs to the downdraft routine, but to the outputs, which are now mass fluxes not tendencies. The water and thermodynamic budgets remain satisfied now. I’ve attached my version below. It should be pretty close to your version with regards to the interface so you shouldn’t have to do much work with it. Regards, Don

lisa-bengtsson commented 5 months ago

@AnningCheng-NOAA it says 397 files are changed in this PR? Should it go into something more recent in the ufs-community/ccpp repo and not into NCAR main?

AnningCheng-NOAA commented 5 months ago

Lisa, Those 397 files are likely changed after I checked out the trunk a few weeks ago. I have only modified the cs_conv.F90. There should be numerous conflicts when I merged my branches with the trunk again.

dustinswales commented 5 months ago

@AnningCheng-NOAA Can you please close this PR and open it in https://github.com/ufs-community/ccpp-physics? (It seems from the commit log that is where you branched your work from)

AnningCheng-NOAA commented 5 months ago

closed PR was put to the wrong repo.

AnningCheng-NOAA commented 5 months ago

Done. @Dustin Swales - NOAA Federal @.***> .

On Tue, Feb 13, 2024 at 10:34 AM Dustin Swales @.***> wrote:

@AnningCheng-NOAA https://github.com/AnningCheng-NOAA Can you please close this PR and open it in https://github.com/ufs-community/ccpp-physics ? (It seems from the commit log that is where you branched your work from)

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/1063#issuecomment-1941803048, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIOLLEEXQOZEKWAFUY3YTOBZFAVCNFSM6AAAAABDFQWPTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRHAYDGMBUHA . You are receiving this because you were mentioned.Message ID: @.***>