NCAR / ccpp-physics

GFS physics for CCPP
Other
56 stars 144 forks source link

Match ozone diagnostics to terms of the parametrization #1068

Closed DWesl closed 2 months ago

DWesl commented 3 months ago

I changed each diagnostic to correspond to a single term in the parametrization, rather than one-and-a-half and then the sum of all four.

That is, the first diagnostic of the old version was the first term of the parametrization plus the part of the second term that does not uses variables at the future time in the implicit update step (the $\left.\frac{d(P-L)}{dr}\right|_0 (r - r_0)$ term is implicit in r; the first diagnostic included the $r_0$ part and excluded the $r(t+dt)$ part), and the second looked like the total photochemical tendency from the scheme, which the driver could accumulate on its own. In the new version, each diagnostic in run_o3prog_2015 corresponds to a term of the equation in the documentation.

grantfirl commented 2 months ago

@DWesl This can be closed since https://github.com/ufs-community/ccpp-physics/pull/196 exists. It'll be brought back to this fork by us code managers.