search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 146 forks source link

UFS-dev PR#184 #1073

Closed grantfirl closed 4 months ago

grantfirl commented 4 months ago

Contains changes from

mkavulich commented 4 months ago

@grantfirl Does this update require SCM changes as well? When I updated my SCM branch to use this physics branch, prebuild fails with an error:

DEBUG: Requested variable zenith_angle_temporal_adjustment_factor_for_shortwave_fluxes in MODULE_ysuvdif SCHEME_ysuvdif SUBROUTINE_ysuvdif_run matched to target physics%Interstitial%xmu in module CCPP_typedefs
Traceback (most recent call last):
  File "/Volumes/d1/kavulich/CCPP/rename_suite_files/grants_pr/mybranch/ccpp-scm/ccpp/framework/scripts/ccpp_prebuild.py", line 827, in <module>
    main()
  File "/Volumes/d1/kavulich/CCPP/rename_suite_files/grants_pr/mybranch/ccpp-scm/ccpp/framework/scripts/ccpp_prebuild.py", line 783, in main
    raise Exception('Call to compare_metadata failed.')
Exception: Call to compare_metadata failed.
mkavulich commented 4 months ago

Sorry, I just now saw your comment here, disregard