search

NCAR / ccpp-physics

Collection of physics parameterizations compliant with the Common Community Physics Package (CCPP) framework
Other
60 stars 146 forks source link

Rework SHOC #187

Closed climbfuji closed 5 years ago

climbfuji commented 6 years ago

The SHOC scheme (gcm_shoc.F90) should be reworked so that it looks a bit more familiar to the physics developers.

Currently, the CCPP entry point uses different variable names than the FV3 version of the code, and passes them in in a different order. The set of variables is also different, mainly because some of the interstitial code is added to the CCPP entry point.

Depending on whether it is required to run SHOC after convection or not, some of the complexity can be removed or not. Making a few modifications to let the entry point look more familiar to the physics developer would be helpful with the code review and acceptance process.

climbfuji commented 5 years ago

@grantfirl any progress on this one? I assume it would be best to have this done before we are handing the code over to EMC for integration into VLAB master?

climbfuji commented 5 years ago

Since SHOC v2 will be added from scratch, this is no longer relevant.