Closed grantfirl closed 2 years ago
grantfirl
commented
2 years ago Thanks @mzhangw . Both you and @mjiacono agree on a need to make sure iovr==4/5 are exercised in UFS RTs. I see that iovr==1 is in default_vars.sh and iovr==3 is exercised in several RTs, but I don't see any iovr==4/5 yet. I'll inquire about adding some. Maybe we can switch an existing RT to use these to save on the number of RTs.
grantfirl
commented
2 years ago @Qingfu-Liu As codeowner of some of these files, would you please review these changes from @mjiacono ?
grantfirl
commented
2 years ago All, thanks for the reviews. @mzhangw @mjiacono The new RTs that exercise iovr=4 and iovr=5 are OK with EMC code managers (see https://github.com/ufs-community/ufs-weather-model/pull/1025). I'm rerunning RTs after addressing some reviewer comments in the ufs-weather-model PR, but this should be good to merge and is tentatively on the merge schedule for tomorrow.
Qingfu-Liu
commented
2 years ago I am working to clear up the code (finished the old version), and moving all the calls to the subroutine "progcld*" to this module, and will move this section of the code to the outside of those calls. Qingfu
On Thu, Jan 27, 2022 at 3:46 PM Dom Heinzeller @.***> wrote:
@.**** approved this pull request.
In physics/radiation_clouds.f https://github.com/NCAR/ccpp-physics/pull/830#discussion_r793985094:
@@ -876,6 +876,19 @@ subroutine progcld1 & alpha(:,:) = 0. endif
- ! Revise alpha for exponential-random cloud overlap
This is exactly the same block of code, nine times, in the same file. In a future cleanup of the code, one could make this a separate subroutine to call from the various places.
— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/830#pullrequestreview-865408972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGTS6UUDZ6VWIPEMCLCHIQTUYGVJFANCNFSM5MNQVL7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
grantfirl
commented
2 years ago I'll chime in and add that I've been saying for years that all of the "interstitials" surrounding radiation need a thorough reorganization/cleanup, especially in light of RRTMG and RRTMGP both being in the CCPP now. The current organization of interstitials was flawed from the beginning, IMO.
dustinswales
commented
2 years ago I'll chime in and add that I've been saying for years that all of the "interstitials" surrounding radiation need a thorough reorganization/cleanup, especially in light of RRTMG and RRTMGP both being in the CCPP now. The current organization of interstitials was flawed from the beginning, IMO.
^This
dustinswales
commented
2 years ago I am working to clear up the code (finished the old version), and moving all the calls to the subroutine "progcld*" to this module, and will move this section of the code to the outside of those calls. Qingfu
@Qingfu-Liu This is great to hear!
When implementing GP I generalized much of the code in proglcd, which may be useful to you. In RRTMG, "progcld" is called from GFS_rrtmg_pre.F90. In RRTMGP this is broken down into 4 pieces:
I'm happy to work with you to "mash this together" into some shared radiation infrastructure in the CCPP.
yangfanglin
commented
2 years ago I have asked Qingfu to write down his plan and share with relevant parties to discuss and come up with a better approach.
Qingfu-Liu
commented
2 years ago This is what I am currently doing for the calculation of cloud radiation properties for different microphysics (any comments and suggestions are welcome): 1) added a new subroutine "radiation_clouds_prop" in the "module_radiation_clouds". This new subroutine will include all the subroutine calls to following subroutines: ! internal accessable subroutines: ! ! 'progcld1' --- zhao/moorthi prognostic cloud scheme ! ! 'progcld2' --- inactive ! ! 'progcld3' --- zhao/moorthi prognostic cloud + pdfcld ! ! 'progcld4' --- GFDL-Lin cloud microphysics ! ! 'progcld4o' --- inactive ! ! 'progcld5' --- Ferrier-Aligo cloud microphysics ! ! 'progcld6' --- Thompson/wsm6 cloud microphysics (EMC) ! ! 'progclduni' --- MG cloud microphysics ! ! --- GFDL cloud microphysics (EMC) ! ! --- Thompson + MYNN PBL (or GF convection) ! ! 'progcld_thompson' --- Thompson MG (added by G. Thompson)
The subroutine calls are removed from subroutine "GFS_rrtmg_pre_run".By doing this, we will wrap all the calculations of the cloud radiation properties in one module. I have gone through those individual subroutines (progcld1, progcld3, progcld4, ... ), I think it may be better to keep them separate since they are for different microphysics schemes, although some of them are very similar (still different). I will also move some common code to the outside of those subroutines if possible, and add them to the new subroutine. Qingfu
On Thu, Jan 27, 2022 at 5:29 PM Fanglin Yang @.***> wrote:
I have asked Qingfu to write down his plan and share with relevant parties to discuss and come up with a better approach.
— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/830#issuecomment-1023700851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGTS6UROZEZAT44ZSS4P6NLUYHBLBANCNFSM5MNQVL7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
All credit to @mjiacono for this PR. All descriptions that follow are his. This replacement PR for #829 is for convenience only.
This PR addresses part 2 of issue #748 to activate the exponential-random cloud overlap method (iovr=5) in RRTMG.