Address Issue #863 (setting surface-related interstitial variables for SCM prescribed-surface-flux mode)

NCAR / ccpp-physics

GFS physics for CCPP

Other

59 stars 146 forks source link

Address Issue #863 (setting surface-related interstitial variables for SCM prescribed-surface-flux mode) #870

Closed grantfirl closed 2 years ago

grantfirl commented 2 years ago

Fixes #863
Changes answer for prescribed-surface flux SCM cases
Will not affect FV3/UFS at all
Copy some of the code from GFS_surface_composites_pre_run into scm_sfc_flux_spec_run for setting some surface-related interstitial variables that are used in non-surface-related schemes after scm_sfc_flux_spec_run
This requires executed scm_sfc_flux_spec_run prior to dcyc2 in the SDFs to work

grantfirl commented 2 years ago

@climbfuji Since this won't change the answer for UFS RTs, is there any way that this can be combined with Jeff Beck's bugfix for SPP and merged with https://github.com/NOAA-EMC/fv3atm/pull/487?

climbfuji commented 2 years ago

@climbfuji Since this won't change the answer for UFS RTs, is there any way that this can be combined with Jeff Beck's bugfix for SPP and merged with NOAA-EMC/fv3atm#487?

Fine with me. Note please that I will be on "NOAA leave" the entire next week March 7-11, so either this gets done tomorrow or from the 14th on.

grantfirl commented 2 years ago

@climbfuji Since this won't change the answer for UFS RTs, is there any way that this can be combined with Jeff Beck's bugfix for SPP and merged with NOAA-EMC/fv3atm#487?

Fine with me. Note please that I will be on "NOAA leave" the entire next week March 7-11, so either this gets done tomorrow or from the 14th on.

OK, understood. I'd be surprised if your PRs go in tomorrow since there is supposed to be one in between NSSL and yours. Depending on what happens tomorrow, maybe I'll see if I can get this in separately or as part of something else next week.