search

NCAR / ccpp-physics

GFS physics for CCPP
Other
59 stars 146 forks source link

Need to improve alignment between schemes/module names and file names #878

Closed ligiabernardet closed 2 years ago

ligiabernardet commented 2 years ago

Every scheme should be its own file (no multiple schemes per file), and there should be better alignment between schemes/module names and file names.

dustinswales commented 2 years ago

I will be the first to admit that RRTMGP is probably the most prolific offender here, at least by file count. I can imagine combing some modules, but never all down into one file. The GP code is organized to distinguish the different pieces of the radiation problem.

ligiabernardet commented 2 years ago

@dustinswales This issue refers to having the name of the Fortran file for a scheme entry pointy match the name of the scheme/module. It is fine for a scheme to have dependencies, that is, for a scheme to be composed of multiple files. Hopefully @grantfirl can explain better than me.