search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

release/p8c: updated PBL and convection schemes plus a bug fix for the Thompson scheme #882

Closed ChunxiZhang-NOAA closed 2 years ago

ChunxiZhang-NOAA commented 2 years ago

The updates of the TKE-EDMF PBL scheme and the saSAS cumulus scheme for P8C (see issue #881).

Note that the updates of these two schemes will cause results changes of many regression tests. Regression tests were done on Hera.

JongilHan66 commented 2 years ago

Chunxi,

It may be better to add the ppt file I sent to you into #881. You can say "Details of the updates are found here" by having a link to the ppt file in 'here'.

Jongil

On Tue, Mar 15, 2022 at 11:25 AM ChunxiZhang-NOAA @.***> wrote:

The updates of the TKE-EDMF PBL scheme and the saSAS cumulus scheme for P8C (see issue #881 https://github.com/NCAR/ccpp-physics/issues/881).

You can view, comment on, or merge this pull request online at:

https://github.com/NCAR/ccpp-physics/pull/882 Commit Summary

File Changes

(5 files https://github.com/NCAR/ccpp-physics/pull/882/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/882, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHEH2QZ3KIAK5R6DDH4KDVACTXBANCNFSM5QZBDTHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because your review was requested.Message ID: @.***>

--

Jongil Han, PhD

NOAA/NWS/NCEP/EMC

5830 University Research Ct., Rm. 2091

College Park, MD 20740

@.***

301-683-3788

ChunxiZhang-NOAA commented 2 years ago

@JongilHan66 Done as you suggested.

grantfirl commented 2 years ago

@ChunxiZhang-NOAA Please add upstream pull requests for fv3atm and ufs-weather-model. For testing on the merge date, it will be helpful to document a list of tests that are expected to fail due to changed baselines.

ChunxiZhang-NOAA commented 2 years ago

@grantfirl @climbfuji There are more updates to the TKE-EDMF and saSAS schemes recently. I am thinking of updating this PR. Is it ok?

grantfirl commented 2 years ago

@grantfirl @climbfuji There are more updates to the TKE-EDMF and saSAS schemes recently. I am thinking of updating this PR. Is it ok?

@ChunxiZhang-NOAA Sure. It looks like it is in the queue for Friday, so that should be plenty of time to re-review if necessary.

ChunxiZhang-NOAA commented 2 years ago

@ChunxiZhang-NOAA The changes look good to me. Are all changes finalized for the merge queue at this point?

@grantfirl Yes, all changes are finalized for the merge.

JongilHan66 commented 2 years ago

Chunxi, where can I find changes in GFS_typedefs.F90?

ChunxiZhang-NOAA commented 2 years ago

Chunxi, where can I find changes in GFS_typedefs.F90?

@JongilHan66 You can it here: https://github.com/NOAA-EMC/fv3atm/pull/503

JongilHan66 commented 2 years ago

@ChunxiZhang-NOAA I can see the changes. Thanks!!

ChunxiZhang-NOAA commented 2 years ago

@ChunxiZhang-NOAA I can see the changes. Thanks!!

@JongilHan66 You are welcome.