Closed wzzheng90 closed 2 years ago
grantfirl
commented
2 years ago @wzzheng90 It looks like the changes in this pull request are identical to #873 except for one extra commit: https://github.com/NCAR/ccpp-physics/pull/885/commits/4284846e2110f9c6e6781de2c002ae35964f03a1
Is the intent for this PR to be committed after #873, or would you like to combine them? @HelinWei-NOAA
grantfirl
commented
2 years ago @wzzheng90 Also, to confirm, this is needed for P8c?
HelinWei-NOAA
commented
2 years ago Weizheng was supposed to create PR on my fork but accidentally on the NCAR repository. Can you please delete this PR? Thanks.
On Fri, Mar 18, 2022 at 11:49 AM Grant Firl @.***> wrote:
@wzzheng90 https://github.com/wzzheng90 It looks like the changes in this pull request are identical to #873 https://github.com/NCAR/ccpp-physics/pull/873 except for one extra commit: 4284846 https://github.com/NCAR/ccpp-physics/commit/4284846e2110f9c6e6781de2c002ae35964f03a1
Is the intent for this PR to be committed after #873 https://github.com/NCAR/ccpp-physics/pull/873, or would you like to combine them? @HelinWei-NOAA https://github.com/HelinWei-NOAA
— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/885#issuecomment-1072539369, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHKYDJ27O3SLVYATGYYATVASQXXANCNFSM5RCE4IXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
grantfirl
commented
2 years ago Weizheng was supposed to create PR on my fork but accidentally on the NCAR repository. Can you please delete this PR? Thanks. … On Fri, Mar 18, 2022 at 11:49 AM Grant Firl @.> wrote: @wzzheng90 https://github.com/wzzheng90 It looks like the changes in this pull request are identical to #873 <#873> except for one extra commit: 4284846 <4284846> Is the intent for this PR to be committed after #873 <#873>, or would you like to combine them? @HelinWei-NOAA https://github.com/HelinWei-NOAA — Reply to this email directly, view it on GitHub <#885 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHKYDJ27O3SLVYATGYYATVASQXXANCNFSM5RCE4IXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>
Sure, no problem.
wzzheng90
commented
2 years ago Hi, Helin and Grant,
Sorry for this mistake. I am going to create it on the right site (Helin's fork). Thank you very much!
Weizhong
On Fri, Mar 18, 2022 at 12:09 PM Grant Firl @.***> wrote:
Weizheng was supposed to create PR on my fork but accidentally on the NCAR repository. Can you please delete this PR? Thanks. … <#m-6231052775691829775> On Fri, Mar 18, 2022 at 11:49 AM Grant Firl @.> wrote: @wzzheng90 https://github.com/wzzheng90 https://github.com/wzzheng90 https://github.com/wzzheng90 It looks like the changes in this pull request are identical to #873 https://github.com/NCAR/ccpp-physics/pull/873 <#873 https://github.com/NCAR/ccpp-physics/pull/873> except for one extra commit: 4284846 https://github.com/NCAR/ccpp-physics/commit/4284846e2110f9c6e6781de2c002ae35964f03a1 <4284846 https://github.com/NCAR/ccpp-physics/commit/4284846e2110f9c6e6781de2c002ae35964f03a1> Is the intent for this PR to be committed after #873 https://github.com/NCAR/ccpp-physics/pull/873 <#873 https://github.com/NCAR/ccpp-physics/pull/873>, or would you like to combine them? @HelinWei-NOAA https://github.com/HelinWei-NOAA https://github.com/HelinWei-NOAA https://github.com/HelinWei-NOAA — Reply to this email directly, view it on GitHub <#885 (comment) https://github.com/NCAR/ccpp-physics/pull/885#issuecomment-1072539369>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHKYDJ27O3SLVYATGYYATVASQXXANCNFSM5RCE4IXA https://github.com/notifications/unsubscribe-auth/ALPHKYDJ27O3SLVYATGYYATVASQXXANCNFSM5RCE4IXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>
Sure, no problem.
— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/885#issuecomment-1072561140, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALOCL23RKSXBE5GM7H2VBODVASTERANCNFSM5RCE4IXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
-- Weizhong Zheng, Dr. IMSG at Environmental Modeling Center NCEP/NWS/NOAA 5830 University Research Court , #2028 College Park, MD 20740 TEL: 301-683-3694 (O) FAX: 301-683-3703 Email: @. @.>
Revised sensible heat flux for under-canopy sublayer in Noah-MP land surface model. -- Modify the eddy diffusivity coefficients for momentum and heat at the top of the canopy. -- Tune the parameters cd (the drag coefficient of leaves) and lm (mean mixing length).