NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

[bug] physics/module_sf_noahmplsm.f90 contains preprocessor directives #886

Closed climbfuji closed 1 year ago

climbfuji commented 2 years ago

Description

File physics/module_sf_noahmplsm.f90 (and possibly others) contain preprocessor (CPP) directives, but the extension is lowercase .f90. This requires the build system to explicitly set -fpp to force preprocessing of all Fortran files.

The correct way to do this is to use .F90 so that the compiler knows from the extension whether preprocessing is required or not.

Steps to Reproduce

  1. Check out the ufs-weather-model code and remove -fpp from cmake/Intel.cmake
  2. Compile the code with Intel
dustinswales commented 1 year ago

Resolved in #956