NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

Bring AQM model into UFS #889

Closed BrianCurtis-NOAA closed 2 years ago

BrianCurtis-NOAA commented 2 years ago

The changes here are work completed by @rmontuoro to bring AQM model into UFS.

UFS Issue: https://github.com/ufs-community/ufs-weather-model/issues/1097 UFS PR: https://github.com/ufs-community/ufs-weather-model/pull/1137

climbfuji commented 2 years ago

@BrianCurtis-NOAA Is this required for any of the prototypes 8b,c? Or for CCPP v6?

BrianCurtis-NOAA commented 2 years ago

@BrianCurtis-NOAA Is this required for any of the prototypes 8b,c? Or for CCPP v6?

It is not required. We do want to get it committed ASAP for UFS-AQM project so we can move to our next steps.

climbfuji commented 2 years ago

@BrianCurtis-NOAA Is this required for any of the prototypes 8b,c? Or for CCPP v6?

It is not required. We do want to get it committed ASAP for UFS-AQM project so we can move to our next steps.

Thanks, will add it to the queue. The CCPPv6/P8 PRs need to go in first, however.

yangfanglin commented 2 years ago

@HelinWei-NOAA The AQM will not be included in any of the coupled model prototypes. However, the AQM should be updated to work with NOAH MP in the next PR if not this one.

BrianCurtis-NOAA commented 2 years ago

@grantfirl The UFS PR has passed all RT's and CI. Ready to start merging.

grantfirl commented 2 years ago

@BrianCurtis-NOAA Done