search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

Update sfc_ocean to accept atmosphere-ocean fluxes from external component. #894

Closed uturuncoglu closed 2 years ago

uturuncoglu commented 2 years ago

This PR aims to update sfc_ocean to accept atmosphere-ocean fluxes from external component. This is tested under UFS model on NCAR's Cheyenne and all RTs are passing without any issue.

uturuncoglu commented 2 years ago

@climbfuji the branch is also updated.

uturuncoglu commented 2 years ago

This is ready to review

grantfirl commented 2 years ago

Thanks @uturuncoglu . I'll review soon. Assuming that the reviews for this and all other repos are OK, what is your preference for adding this work to the UFS merge queue?

uturuncoglu commented 2 years ago

@grantfirl Thanks. Other PRs are still in review and I am trying to run opnReqTest for newly added RT for exchange grid work. I think ccpp/physics mods are closely related with FV3. So, I am not sure what will be the merge queue order at this point. I think after review we could wait little bit for finishing required tests.

grantfirl commented 2 years ago

@grantfirl Thanks. Other PRs are still in review and I am trying to run opnReqTest for newly added RT for exchange grid work. I think ccpp/physics mods are closely related with FV3. So, I am not sure what will be the merge queue order at this point. I think after review we could wait little bit for finishing required tests.

OK. The UFS code managers operate via a bi-weekly meeting that happens to be tomorrow in order to schedule commit order. Since this is at least related to CCPP (and I'm in charge of CCPP PRs), I'll bring it up so that we may tentatively put this on the schedule for the next couple weeks. Will you be around in the next couple weeks for final testing/merging?

uturuncoglu commented 2 years ago

@grantfirl That. That sounds fine. Yes. I'll be here for any change request.

ChunxiZhang-NOAA commented 2 years ago

Thanks @uturuncoglu . I'll review soon. Assuming that the reviews for this and all other repos are OK, what is your preference for adding this work to the UFS merge queue?

@uturuncoglu I will review it soon.

grantfirl commented 2 years ago

@uturuncoglu What is the status of this PR? Is it ready to be scheduled for commit?

uturuncoglu commented 2 years ago

@grantfirl Sorry about the delay. There was an issue in the ORT tests but most of them is solved. I just need to make very minor modification in RT test and change one of the option there. Then, the PR will be ready to merge. It was on hold but I think it will se scheduled soon.

uturuncoglu commented 2 years ago

@grantfirl The top level UFS PR passes all the tests and we are merging sub-components one by one. Before merging FV3, we need to merge CCPP related ones. Please let me know if you need anything from my side to merge CCPP physics and framework PRs.

climbfuji commented 2 years ago

@uturuncoglu ccpp-physics PR merged. New hash is https://github.com/NCAR/ccpp-physics/commit/1a9b050c342541b24638053dd7dcd60dd8653c7e for NCAR ccpp-physics main, please update your submodule pointer in fv3atm.

uturuncoglu commented 2 years ago

@climbfuji thanks. I'll update the UFS model soon.