search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

A bug fix for wet scavenging of aerosols and a minor modification for moisture property calculation #900

Closed ChunxiZhang-NOAA closed 2 years ago

ChunxiZhang-NOAA commented 2 years ago

A bug fix in mass flux divergence computation for wet scavenging of aerosols and a minor modification in moisture property calculation for the saSAS cumulus scheme. Please see issue #898. This bug fix was done by Jongil Han and Kate Zhang.

mzhangw commented 2 years ago

Thanks for confirming it.

On Fri, Apr 15, 2022 at 10:43 AM JongilHan66 @.***> wrote:

@.**** commented on this pull request.

In physics/samfdeepcnv.f https://github.com/NCAR/ccpp-physics/pull/900#discussion_r851370403:

@@ -1641,12 +1643,10 @@ subroutine samfdeepcnv_run (im,km,itc,ntc,cliq,cp,cvap, & qrch = qeso(i,k) & + gamma dbyo(i,k) / (hvap (1. + gamma)) cj

  • tem = 0.5 (xlamue(i,k)+xlamue(i,k-1)) dz
  • tem1 = 0.25 (xlamud(i,k)+xlamud(i,k-1)) dz
  • tem = 0.25 (xlamue(i,k)+xlamue(i,k-1)) dz

Since the 'detraining' effect is taken into account later in computation of mass flux divergence of moisture, I think the description is still ok.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/900#discussion_r851370403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2TMXYXEF6ZAGWEEMKDVFGMCDANCNFSM5TQLMNWQ . You are receiving this because your review was requested.Message ID: @.***>

grantfirl commented 2 years ago

Really great documentation of the problem and fix via the powerpoint linked in the issue, thanks! The code changes look good to me.