search

NCAR / ccpp-physics

GFS physics for CCPP
Other
59 stars 146 forks source link

Update NSSL microphysics to fix ORT restart and decomposition tests #904

Closed MicroTed closed 2 years ago

MicroTed commented 2 years ago

In the process of adding a new suite, it was found that rrfs_v1nssl did not pass the ORT restart (rst) and decomposition (dcp) tests. Both of these failures were tracked to mp_nssl.F90. The restart issue simply needed extra logic (using the 'restart' flag) to control the running of a subroutine on the first time step. The dcp test seems to be solved by replacing 0.0 with 0.0_rkind_phys.

ORT tests run on hera RT for rrfs_v1nssl run on jet

Fixes issue raised in https://github.com/NOAA-EMC/fv3atm/pull/514

junwang-noaa commented 2 years ago

@grantfirl Yes, please point to fv3atm PR#504 so that we can get the reproducibility issue fixed in Ted's ufs PR. @MicroTed Nice work! Thanks for fixing the issues!

grantfirl commented 2 years ago

@MicroTed We just merged in the previous ccpp-physics PR and we'll get yours in next. Please merge in the latest main branch of ccpp-physics (commit: https://github.com/NCAR/ccpp-physics/commit/7e3535134272169e5ae4690aa47e4e9325aefc64) into this branch before pointing your fv3atm PR branch to this.

grantfirl commented 2 years ago

Fixes https://github.com/NCAR/ccpp-physics/issues/916