search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

merge gsl institutional fork #911

Closed SamuelTrahanNOAA closed 2 years ago

SamuelTrahanNOAA commented 2 years ago

This includes surface layer, PBL, gravity wave drag, smoke, and other improvements from GSL RRFS and global model development.

mzhangw commented 2 years ago

You may consider to mimic the two “extinction” examples in the CF standard names: volume_extinction_coefficient_in_air_due_to_ambient_aerosol_particles <> volume_extinction_coefficient_in_air_due_to_cloud_particles <>

On Apr 27, 2022, at 9:20 AM, Samuel Trahan (NOAA contractor) @.***> wrote:

@SamuelTrahanNOAA commented on this pull request.

In physics/GFS_rrtmg_pre.meta https://github.com/NCAR/ccpp-physics/pull/911#discussion_r859932530:

@@ -1194,6 +1194,29 @@ type = real kind = kind_phys intent = out +[aero_dir_fdb]

  • standard_name = rrfs_smoke_dust_rad_fdb_opt
  • long_name = flag for rrfs smoke dust rad feedback
  • units = flag
  • dimensions = ()
  • type = logical
  • intent = in +[smoke_ext]
  • standard_name = smoke_ext The correct name is "smoke_optical_extinction"

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/911#discussion_r859932530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2W6DOXSIHBCMU5K5S3VHFLLRANCNFSM5UNJR34Q. You are receiving this because your review was requested.

SamuelTrahanNOAA commented 2 years ago

You may consider to mimic the two “extinction” examples in the CF standard names: volume_extinction_coefficient_in_air_due_to_ambient_aerosol_particles volume_extinction_coefficient_in_air_due_to_cloud_particles

@haiqinli Please give me better names for these two variables: smoke_ext, dust_ext.

haiqinli commented 2 years ago

You may consider to mimic the two “extinction” examples in the CF standard names: volume_extinction_coefficient_in_air_due_to_ambient_aerosol_particles volume_extinction_coefficient_in_air_due_to_cloud_particles

@haiqinli Please give me better names for these two variables: smoke_ext, dust_ext.

They are the additional optical extinction due to smoke and dust in each model layer. We can use followings.

smoke_ext: extinction_coefficient_in_air_due_to_smoke dust_ext: extinction_coefficient_in_air_due_to_dust

ligiabernardet commented 2 years ago

@SamuelTrahanNOAA Given that the release branch for CCPP v6 to be used in the upcoming UFS SRW v2 and CCPP v6 releases has already been cut, these changes will not be part of the release. I just wanted to make sure we are all on the same page about this. In particular, Flake will not be part of the HRRR suite in the release. If you have a different understanding, please let us know. (attn: @JeffBeck-NOAA

SamuelTrahanNOAA commented 2 years ago

These changes are not intended for the CCPP v6 release. We're doing this PR to get months of GSL physics development into the community repositories. If they end up in the release, then hey! that's great, but it isn't our goal.

grantfirl commented 2 years ago

@SamuelTrahanNOAA I'm assuming that there are plans to merge main into gsl/develop too? And that this will happen after this PR is merged?

SamuelTrahanNOAA commented 2 years ago

I'm assuming that there are plans to merge main into gsl/develop too? And that this will happen after this PR is merged?

Your assumption is correct. The gsl/develop branch is frozen until then.

grantfirl commented 2 years ago

@SamuelTrahanNOAA @haiqinli @joeolson42 I'm finished reviewing the physics changes. Now, my eyeballs hurt. Regardless, this is a phenomenal amount of work and it is to be commended! I'll leave it up to you guys what you want to address now vs what can be done in a followup since 1) there is a commit date and 2) your fork/branch is on hold until this gets in. Pretty much all comments are suggestions only and are not meant to be "change this or else". The CCPP has its rules, and I'm trying to point out where they are violated, but as has been pointed out by many people many times, these rules are violated all over the repo in various places. Nevertheless, we should try our best to fix the "big" ones that could affect interoperability. I'll stop by and review again (and approve) when you're done with any edits from my comments, just let me know. I'll need to look at the fv3atm PR now for standard name suggestions...

SamuelTrahanNOAA commented 2 years ago

I'm fixing all of the stops and gotos, and Haiqin is working on the constants.

SamuelTrahanNOAA commented 2 years ago

I've removed all stops and gotos from the smoke code. The stops are replaced with errmsg and errflag assignments, so the error will propagate up the model framework and abort the model cleanly.

BrianCurtis-NOAA commented 2 years ago

We are ready for commit.