search

NCAR / ccpp-physics

GFS physics for CCPP
Other
59 stars 146 forks source link

Couple GOCART to RRTMGP #917

Closed grantfirl closed 7 months ago

grantfirl commented 2 years ago

Description

Couple GOCART to RRTMGP; https://github.com/NCAR/ccpp-physics/pull/910 only couples GOCART to RRTMG.

Solution

@dustinswales identified a solution in the comments of https://github.com/NCAR/ccpp-physics/pull/910

Related to (optional)

https://github.com/NCAR/ccpp-physics/pull/910

dustinswales commented 2 years ago

RRTMGP is compatible with GOCART aerosols. For background, both RRTMG and RRTMGP use the same fields from the aerosol model (or climatology) and the same code to compute the aerosol optical properties. This makes RRTMGP agnostic to aerosol model changes.

dustinswales commented 2 years ago

@grantfirl I see now that this is not resolved. There have been changes since I last looked at this, https://github.com/NCAR/ccpp-physics/commit/a02422c45b06f46cf0a61ccfcd3083666b2918d0. These need to be propagated to the GP side.

grantfirl commented 7 months ago

@dustinswales Do you know if this is still an issue that needs to be addressed?