Closed SamuelTrahanNOAA closed 2 years ago
I did not apply the changes needed at the ufs-weather-model or fv3atm level to get it to compile with 32 bits. That would be easy to add. Should I?
I did not apply the changes needed at the ufs-weather-model or fv3atm level to get it to compile with 32 bits. That would be easy to add. Should I?
I don't know that we need to merge changes in parent repos in order to enable compiling, but I'm guessing that this code should be able to compile before we merge it (this was Dom's requirement). Has it complied successfully in single precision?
You'd need pretty much everything from my other 32-bit PR. It would just be a non-draft version of that PR.
Ligia's instructions were to do a PR that only compiles 64 bits, but contains all of the CCPP 32-bit changes. That is this PR. She said the next step is to get it to actually run, which is the purpose of the other PR. At this point, the other PR will compile 32 bit but not run, and this one won't compile or run 32 bits.
If it can compile in 32 bit mode using changes in the other draft PR, then that is good enough for me.
As of this posting, this PR is up-to-date with all submodules and has passed intel compiler tests (on jet) and gnu compiler tests (on hera).
I'm hoping @michalakes can review this and comment on the types. He has no repository access yet though, so I'll have to add him and hope he answers soon.
@SamuelTrahanNOAA @grantfirl UFS RT passed. Ready for merge.
This adds changes from NRL to add 32-bit physics support to their model. The changes are a subset of https://github.com/NCAR/ccpp-physics/pull/772 and it replaces the prior attempt at this PR, https://github.com/NCAR/ccpp-physics/pull/797