search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

"smoke" location? #925

Closed dustinswales closed 2 years ago

dustinswales commented 2 years ago

Description

Why are the smoke files not located in the physics? They are at the same level:

SMOKE

'physics/smoke/rrfs_smoke_wrapper.F90',
'physics/smoke/rrfs_smoke_postpbl.F90',
'physics/smoke/rrfs_smoke_lsdep_wrapper.F90',

But... I think that the "smoke" directory belongs in physics/.

SMOKE

'physics/physics/smoke/rrfs_smoke_wrapper.F90',
'physics/physics/smoke/rrfs_smoke_postpbl.F90',
'physics/physics/smoke/rrfs_smoke_lsdep_wrapper.F90',

Thoughts?

ligiabernardet commented 2 years ago

Tks for bringing this up. @SamuelTrahanNOAA is communicating to @haiqinli to address this

haiqinli commented 2 years ago

@dustinswales Thanks for your good point. Yes, I agree it is better to make smoke as a subdirectory of "physics/smoke" like "physics/rte-rrtmgp".

SamuelTrahanNOAA commented 2 years ago

This PR in the gsl fork moves those files:

https://github.com/NOAA-GSL/ccpp-physics/pull/154

dustinswales commented 2 years ago

Thanks @SamuelTrahanNOAA