Closed SamuelTrahanNOAA closed 2 years ago
Looks fine. Approved.
I've merged #1192 to this branch, and both the hera.intel and hera.gnu tests still pass. The results of the new 32-bit physics tests don't change, nor do the existing tests. These tests also included the variable name change suggested in one of the comments.
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. The 64-bit physics should not change results. See #923 for past conversation and https://github.com/ufs-community/ufs-weather-model/pull/1215 for the top-level PR.
About half of these changes come from @DusanJovic-NOAA, and a little bit from @climbfuji and @grantfirl. The work is based on a similar project by @michalakes in the NRL Neptune model, which also uses CCPP.
Issues
https://github.com/ufs-community/ufs-weather-model/issues/1288
Dependencies
https://github.com/earth-system-radiation/rte-rrtmgp/pull/180this was already merged