Bug fixes in physics/cu_gf_deep.F90 and physics/cu_gf_driver.F90 for bit-for-bit identical results with GF when changing the MPI decomposition. Instead of using the pefc value of last column (pefc was a scalar), which is incorrect, turn pefc into a vector of length horizontal_loop_extent and use the correct value in GF deep convection.
Minor formatting cleanup in removal of unused symbols/code.
climbfuji
commented
2 years ago
Bug fixes in
physics/cu_gf_deep.F90andphysics/cu_gf_driver.F90for bit-for-bit identical results with GF when changing the MPI decomposition. Instead of using thepefcvalue of last column (pefcwas a scalar), which is incorrect, turnpefcinto a vector of lengthhorizontal_loop_extentand use the correct value in GF deep convection.Minor formatting cleanup in removal of unused symbols/code.
Associated PRs:
https://github.com/NOAA-EMC/fv3atm/pull/543 https://github.com/ufs-community/ufs-weather-model/pull/1243
For regression testing, see https://github.com/ufs-community/ufs-weather-model/pull/1243