search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

moninshoc.meta missing mfpbl.f dependency #934

Closed SamuelTrahanNOAA closed 2 years ago

SamuelTrahanNOAA commented 2 years ago

A recent addition of "module" statements at the top of some files broke moninshoc. This adds a dependency so moninshoc will compile.

Fixes #935

ligiabernardet commented 2 years ago

@SamuelTrahanNOAA Does this affect the release branch and the suites planned for release as part of CCPP v6?

SamuelTrahanNOAA commented 2 years ago

Only if the release branch has JM's Neptune changes.

ligiabernardet commented 2 years ago

The release does not have JM's NEPTUNE changes. Thanks for the prompt reply.

grantfirl commented 2 years ago

@SamuelTrahanNOAA I realize that this PR doesn't change the baseline and https://github.com/NCAR/ccpp-physics/pull/942 does, but since this is just one line, could this be combined into https://github.com/NCAR/ccpp-physics/pull/942 for the sake of saving UFS code managers work?

SamuelTrahanNOAA commented 2 years ago

This has been merged into https://github.com/NCAR/ccpp-physics/pull/942