search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

moninshoc fails to compile because of missing mfpbl.f dependency #935

Closed SamuelTrahanNOAA closed 2 years ago

SamuelTrahanNOAA commented 2 years ago

Description

The moninshoc.meta is missing a dependency after a recent commit. That commit added "module" statements at the top of some files, so moninshoc's Fortran 77-style calls failed.

Fixed by #934

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Try to compile a suite that uses moninshoc (such as FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp)
  2. Behold the error
  3. Sadness

Additional Context

Bug was discovered by @SMoorthi-emc, and was caused by @SamuelTrahanNOAA incorrectly translating adapting changes from NRL's Neptune model.