search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

Removed references to rrtmg_lw_init and rrtmg_sw_init #939

Closed mark-a-potts closed 2 years ago

mark-a-potts commented 2 years ago

Removed undefined references for use with ufs-weather-model release/public-v3 branch used by SRW release/public-v2.

Fixes issue #938

mzhangw commented 2 years ago

Since it was merged already, do you want me to submit a PR to remove *_finalize in both subroutines?

On Jun 8, 2022, at 10:16 AM, Grant Firl @.***> wrote:

Merged #939 https://github.com/NCAR/ccpp-physics/pull/939 into release/public-v6.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/939#event-6771361333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2VEZICFNLKTQ6MDZZTVODBPTANCNFSM5YHC54UA. You are receiving this because your review was requested.

mark-a-potts commented 2 years ago

That would be awesome. Thanks!

-M

On 6/8/22 12:19 PM, mzhangw wrote:

Since it was merged already, do you want me to submit a PR to remove *_finalize in both subroutines?

On Jun 8, 2022, at 10:16 AM, Grant Firl @.***> wrote:

Merged #939 https://github.com/NCAR/ccpp-physics/pull/939 into release/public-v6.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/939#event-6771361333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2VEZICFNLKTQ6MDZZTVODBPTANCNFSM5YHC54UA. You are receiving this because your review was requested.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/939#issuecomment-1150127300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH4Q2UQVWI5KKKKZXSFWRW3VODBZ7ANCNFSM5YHC54UA. You are receiving this because you were mentioned.Message ID: @.***>

--

Mark A. Potts, Ph.D. NOAA EPIC Lead Software Engineer RedLine Performance Solutions, LLC Phone 202-744-9469 @. @.

grantfirl commented 2 years ago

@mzhangw No, in my opinion, we should not touch this branch anymore. Rather than removing these empty subroutines piecemeal, we should do a comprehensive cleanup later on the main branch.