NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

exponentiation instead of multiplication caused bad 2m temperatures #941

Closed SamuelTrahanNOAA closed 2 years ago

SamuelTrahanNOAA commented 2 years ago

Description

A catastrophic typo in the mynn surface layer scheme produces bad 2m temperatures. This was reported and fixed by @joeolson42 in the NOAA-GSL fork. The NCAR main bugfix is in #940

 TH1D(I)=T1D(I)**(100000./P1D(I))**ROVCP !(Theta, K)

The first ** should be a *

 TH1D(I)=T1D(I)*(100000./P1D(I))**ROVCP !(Theta, K)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Read module_sf_mynn
  2. Sadness