search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

revert 2mtq diag method #948

Closed JessicaMeixner-NOAA closed 2 years ago

JessicaMeixner-NOAA commented 2 years ago

This PR its for P8.

author: @HelinWei-NOAA

JessicaMeixner-NOAA commented 2 years ago

@HelinWei-NOAA can you provide any additional description?

HelinWei-NOAA commented 2 years ago

The reason we had this change in the last NoahMP update can be found here. We tried to address the high 2m Td bias over the bare soil area. From mini P8c results, this approach doesn't reduce the bias but unexpectedly increasing the magnitude of the diurnal variation of 2m T. We are testing the other approach but probably can't get it into P8c in time. So for safety we want to revert this change and the way to diagnose 2m T/Q will be the same as P8b, i.e. using sfc_diag.f instead of two-tiled values from NoahMP.

jkbk2004 commented 2 years ago

All tests finished on ufs-wm pr#1338. Can I ask for final review and merging this PR?

grantfirl commented 2 years ago

All tests finished on ufs-wm pr#1338. Can I ask for final review and merging this PR?

@jkbk2004 Done.