search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

Accumulated cleanup #956

Closed dustinswales closed 1 year ago

dustinswales commented 2 years ago

This PR addresses several outstanding issues:

grantfirl commented 1 year ago

@dustinswales What is the status of these changes? Are the RT issues worked out?

dustinswales commented 1 year ago

@dustinswales What is the status of these changes? Are the RT issues worked out?

All of the RT's are working, except the RRTMGP tests (control_p8_rrtmgp, rap_rrtmgp). I've been swamped with other stuff and haven't had a chance to chase these differences down.

ChunxiZhang-NOAA commented 1 year ago

@dustinswales Did the two RRTMGP related PRs pass RT after the bug was fixed?

dustinswales commented 1 year ago

@ChunxiZhang-NOAA We need to generate new baselines for the RRTMGP tests. The seed used by the cloud-sampling was not being set correctly in RRTMGP (my bad). For example, here is the change in the GP baselines with the bug fix to the downward longwave radiation at the surface:

lwdn
ChunxiZhang-NOAA commented 1 year ago

@ChunxiZhang-NOAA We need to generate new baselines for the RRTMGP tests. The seed used by the cloud-sampling was not being set correctly in RRTMGP (my bad). For example, here is the change in the GP baselines with the bug fix to the downward longwave radiation at the surface: lwdn

Good to know, thanks.

grantfirl commented 1 year ago

I'm ready to approve as soon as your PR branch is updated to the latest NCAR/main to get rid of the merge conflicts.

AnningCheng-NOAA commented 1 year ago

Approved the clean-up. There is no problem related to MERRA2 and aerosol.

On Thu, Sep 22, 2022 at 3:58 PM Grant Firl @.***> wrote:

@.**** approved this pull request.

I reviewed and left comments a couple weeks ago and just looked over your recent changes now. Looks good to me.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/pull/956#pullrequestreview-1117605963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIPXMMPJ6Q3QMGSRMSLV7S24VANCNFSM6AAAAAAQAS2ST4 . You are receiving this because your review was requested.Message ID: @.***>

dustinswales commented 1 year ago

@grantfirl FYI I added an updated CODEOWNERS file