search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

No cldfra2d diagnostics saved in RRTMGP #957

Closed mzhangw closed 5 months ago

mzhangw commented 2 years ago

There is no cldfra2d diagnostics in RRTMGP as it does in RRTMG. It leads to an incorrect ZERO value of total cloud fraction when RRTMGP is used in SCM.

dustinswales commented 2 years ago

@mzhangw We need to add the following 5 lines to here, but using cld_frac @yangfanglin @Qingfu-Liu I can add this fix to my open PR, #956?

yangfanglin commented 2 years ago

@dustinswales it appears there are already a lot of changes in PR #956. It might be a good idea to merge this to a different PR. It can be included in a PR @Qingfu-Liu is creating to update cloud condensates in cloud cover and radaition calculations.

dustinswales commented 2 years ago

@yangfanglin That would be excellent. @Qingfu-Liu

dustinswales commented 1 year ago

@yangfanglin @Qingfu-Liu @mzhangw I added a fix to this issue in ufs-community/ccpp-phsyics PR #9

mzhangw commented 1 year ago

It is to add a counterpart of the RRTMG cldfra2d in GP. It looks good to me.

On Oct 7, 2022, at 11:25 AM, dustinswales @.***> wrote:

@yangfanglin https://github.com/yangfanglin @Qingfu-Liu https://github.com/Qingfu-Liu @mzhangw https://github.com/mzhangw I added a fix to this issue in ufs-community/ccpp-phsyics PR #9 https://github.com/ufs-community/ccpp-physics/pull/9 — Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-physics/issues/957#issuecomment-1271856734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TW2VSNRS6IGBUJOBGWBTWCBMHFANCNFSM6AAAAAAQAVB5T4. You are receiving this because you were mentioned.

grantfirl commented 5 months ago

Fixed in https://github.com/ufs-community/ccpp-physics/pull/9