search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

RRTMG cloud condensate overlap #965

Closed grantfirl closed 1 year ago

dustinswales commented 1 year ago

@mjiacono @grantfirl I just walked through this, no major concerns, but I have some questions/comments. There are a few things going on in this PR. First, there is the addition of cloud-condensate overlap. This all looks fine to me, I had a small comment on generalization. Then there's the cloud optics/sampling reordering, which makes sense scientifically, but I would imagine change the results?

grantfirl commented 1 year ago

@mjiacono @grantfirl I just walked through this, no major concerns, but I have some questions/comments. There are a few things going on in this PR. First, there is the addition of cloud-condensate overlap. This all looks fine to me, I had a small comment on generalization. Then there's the cloud optics/sampling reordering, which makes sense scientifically, but I would imagine change the results?

Yes, it looks like the reordering does change the results, according to @mjiacono. He is working on it.

mjiacono commented 1 year ago

I wasn't expecting a change in the original results due to the reordering, but I'm still looking into it.

mjiacono commented 1 year ago

@grantfirl Sorry for letting the work on this PR linger so long. My fork has gotten too far out of sync to resolve, so I'm going to start over on this effort, and I'll get back to you when ready to try another PR. You can bench or close PR 965.

grantfirl commented 1 year ago

@grantfirl Sorry for letting the work on this PR linger so long. My fork has gotten too far out of sync to resolve, so I'm going to start over on this effort, and I'll get back to you when ready to try another PR. You can bench or close PR 965.

@mjiacono OK, sounds good. It is probably best to start a new fork from https://github.com/ufs-community/ccpp-physics/tree/ufs/dev if this work is geared toward NOAA models.