search

NCAR / ccpp-physics

GFS physics for CCPP
Other
58 stars 145 forks source link

Bugfix and optimization of prognostic closure for the P8 physics suite #967

Closed lisa-bengtsson closed 1 year ago

lisa-bengtsson commented 1 year ago

This PR corrects a bug when using the prognostic closure (progsigma = true) to compute the q-tendency due to microphysics even if the diagnostic flags are false. It also optimizes the cloudbase massflux value for shallow and deep convection to work with the overall P8 physics suite.

New baselines are needed for the test: control_c384_progsigma

This update does not change the results in the control tests.

It addresses the issue: https://github.com/NCAR/ccpp-physics/issues/960

grantfirl commented 1 year ago

@ChunxiZhang-NOAA This PR seems like it should be targeted toward the ufs-dev branch to me. What do you think? @lisa-bengtsson I'm assuming that you started this work from the top of NCAR/main, correct?

lisa-bengtsson commented 1 year ago

@grantfirl yes that is correct.

ChunxiZhang-NOAA commented 1 year ago

@grantfirl Looks like this PR only impacts one RT control_c384_progsigma and will not change other RTs. This PR is not for operational applications in short term. So I think it can stay here at NCAR/main.