search

NCAR / ccpp-scm

CCPP Single Column Model
Other
14 stars 49 forks source link

Update ccpp-scm to work with ccpp-physics branch ccpp_convective_transport_tracers_cleanup from @climbfuji #275

Closed climbfuji closed 3 years ago

climbfuji commented 3 years ago

As the title says:

Update ccpp-scm to work with ccpp-physics branch ccpp_convective_transport_tracers_cleanup from @climbfuji

This PR contains the cumulative changes to run ccpp-scm with the branch ccpp_convective_transport_tracers_cleanup (see https://github.com/NCAR/ccpp-physics/pull/752). This includes several updates in CCPP-SCM due to recent commits.

This PR will get updated whenever https://github.com/NCAR/ccpp-physics/pull/752 gets updated until it is time to merge.

grantfirl commented 3 years ago

@climbfuji It looks like most of the changes in this PR were duplicated in #276 (which was done because a user asked to have the ccpp-scm up-to-date ASAP). I don't know how many of the changes in this PR are specifically for ccpp-physics PR #752 vs just catching up to main. Sorry for making this more difficult!

climbfuji commented 3 years ago

@climbfuji It looks like most of the changes in this PR were duplicated in #276 (which was done because a user asked to have the ccpp-scm up-to-date ASAP). I don't know how many of the changes in this PR are specifically for ccpp-physics PR #752 vs just catching up to main. Sorry for making this more difficult!

Looks like PR #276 contained everything that was needed. Not even my changes in scm/src/scm_type_defs.F90 are necessary. Will close this PR.