search

NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Adding more diagnostics for help with cloud fraction scheme(s) #283

Closed gthompsnWRF closed 2 years ago

gthompsnWRF commented 2 years ago

Six new variables - 2D only - were added to support cloud fraction schemes to diagnose impacts of explicit cloud condensate versus impacts from cloud fraction. There is a corresponding branch with the same name in the ccpp-physics repo to include the new calculations together with a new/updated cloud fraction scheme.

gthompsnWRF commented 2 years ago

The changes add the required variables to the GFS data structure and the CCPP metadata, but I am wondering if there are additional steps needed to output these variables in the single column model? Or has this not been done, because you were using the UFS in your tests?

That's correct. I added these 6 new variables to GFS_diagnostics.F90 to get them for UFS and not really sure what/where to place them in SCM - unless they go in scm_output.F90.

grantfirl commented 2 years ago

The new variables need to be added to scm_output.F90 only. I can do this for you @gthompsnWRF (I'll branch off of your PR branch, make modifications, and submit a PR back into your branch so that it will be reflected here once accepted by you). It's pretty straightforward, but there could be a complication or two depending on what is being held in these variables. The Diag DDT in GFS_typedefs holds variables that can be instantaneous, accumulated, etc. and that needs to be accounted for in how they're written out in scm_output.F90.

grantfirl commented 2 years ago

This PR is superceded by #285, so closing this one.