Last minor tweaks to release code...

NCAR / ccpp-scm

CCPP Single Column Model

Other

13 stars 50 forks source link

Last minor tweaks to release code... #328

Closed grantfirl closed 2 years ago

grantfirl commented 2 years ago

reduce verbosity of run script
minor fix in tutorial plotting config file
better plot rejection message
data retrieval scripts point to v6.0.0 GitHub release assets (to be created)
include modified scm_read_obs.py file in tutorial_files (need to replace existing one in ccpp-scm/scm/etc/scripts for the tutorial)

ligiabernardet commented 2 years ago

Would it be possible to add something else to this PR: In files release/public-v6/contrib/*.sh, the datasets to download should be v6.0.0 and not v5. Note that the v6.0.0 datasets need to be created and staged on the GitHub release page (https://github.com/NCAR/ccpp-scm/releases/download/v6.0.0).

grantfirl commented 2 years ago

Would it be possible to add something else to this PR: In files release/public-v6/contrib/*.sh, the datasets to download should be v6.0.0 and not v5. Note that the v6.0.0 datasets need to be created and staged on the GitHub release page (https://github.com/NCAR/ccpp-scm/releases/download/v6.0.0).

Yes. I can't remember what we did last time with respect to this. Did we simply do a "draft" release or denote it as "pre-release"? We have to setup a release in order to stage these assets to download.

grantfirl commented 2 years ago

@dustinswales This PR now includes updates up through chapter 2 of the User's Guide. I'll integrate the changes that you have in the commit that you posted in Slack.

grantfirl commented 2 years ago

This PR will continue to receive Users Guide updates before merging...