NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Feature DEPHY v1 #370

Closed dustinswales closed 1 year ago

dustinswales commented 1 year ago

This PR adds the ability to use DEPHY v1 forcing files with the SCM.

The changes are isolated to the scm input/output/util modules to accommodate the new format (see DEPHY v1 doc)

There is a new case configuration file and CI test to exercise the SCM's compatibility with the DEPHY repository, ci_run_scm_DEPHY.yml. (If they change their format, yet again, this test will break. At which time we can decide to either update the SCM to use the latest DEPHY format or just use the last working hash in the DEPHY repository.)

This replaces part of #364

dustinswales commented 1 year ago

@grantfirl All tests pass. No changes to baselines.

dustinswales commented 1 year ago

Looks good, @dustinswales . Just a few questions.

@grantfirl Thanks for your review.

There are some documentation changes that I need to add. I don't have a latex editor on my work machine to update main.pdf, and these changes are on my home computer. So I will update the PDF later. Question. Do we update the date on the Users Doc?

grantfirl commented 1 year ago

Looks good, @dustinswales . Just a few questions.

@grantfirl Thanks for your review.

There are some documentation changes that I need to add. I don't have a latex editor on my work machine to update main.pdf, and these changes are on my home computer. So I will update the PDF later. Question. Do we update the date on the Users Doc?

We've only updated the date for releases in the past, but it's also fine if you'd rather do that now too.