search

NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Feature: UFS Replay #372

Closed dustinswales closed 1 year ago

dustinswales commented 1 year ago

The first is the functionality to create SCM cases using standard output from the UFS weather model. The changes contained here are built on-top of https://github.com/grantfirl/ccpp-scm/tree/UFS_forcing_20210203/scm. The dynamic tendencies to drive the SCM are derived in UFS_IC_generator.py. Then, along with the necessary initial conditions, these derived forcing terms are stored in DEPHYv1 format.

dustinswales commented 1 year ago

@grantfirl Documentation added, section 5.5. I think this is ready to go otherwise.

mkavulich commented 1 year ago

@dustinswales I have taken a brief look at the code but was waiting to test it myself as I see you are still making changes to the CI tests. Do you think this PR is stable enough to start a thorough review?

dustinswales commented 1 year ago

@mkavulich Thanks! Yes, it's ready for review. The CI test is working, well mostly. It does two things. A) Creates a UFS-replay case from staged UWM RT data on the DTC FTP website and then B) Builds and runs SCM with the UFS_replay case. It's failing at the very end of the last step.

Maybe this is all too much anyways? Since what we really need is to be alerted to UWM input/output changes that break the case generation script (we have another CI test that does the full workflow for DEPHY formatted input, which is what comes out of the case generation script). The functionality of this test is only useful if the data from the UWM is somewhat up-to-date.

dustinswales commented 1 year ago

@grantfirl The new CI test to create the UFS-replay cases from staged UWM RT data is working, and passing.