NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

UFS-dev PR#42 #374

Closed grantfirl closed 1 year ago

grantfirl commented 1 year ago

Changes to GFS_typedefs to work with ufs/dev #42. The changes are analogous to https://github.com/NCAR/fv3atm/pull/89

grantfirl commented 1 year ago

Contains changes from #373 and depends on it being merged first. Also depends on https://github.com/NCAR/ccpp-physics/pull/1007.

dustinswales commented 1 year ago

@grantfirl I think this is good to go? It's a bit troublesome that we are seeing lots of BL changes in the UWM, but not in here. https://github.com/NCAR/ufs-weather-model/pull/92?

grantfirl commented 1 year ago

@grantfirl I think this is good to go? It's a bit troublesome that we are seeing lots of BL changes in the UWM, but not in here. NCAR/ufs-weather-model#92?

Ya, this probably needs to be verified. I'm also not sure that the failures in UWM are all expected since it wasn't explicitly mentioned in the UFS fork which RTs should fail. I've asked Sam for some clues, but haven't heard back. I'll look at this a bit more later this afternoon.

grantfirl commented 1 year ago

@dustinswales Do you know when the last time ftp://ftp.rap.ucar.edu/pub/ccpp-scm/rt-baselines-Debug.zip was updated?

grantfirl commented 1 year ago

Should https://github.com/NCAR/ccpp-scm/blob/main/test/cmp_rt2bl.py be using nccmp rather than cmp?

dustinswales commented 1 year ago

@dustinswales Do you know when the last time ftp://ftp.rap.ucar.edu/pub/ccpp-scm/rt-baselines-Debug.zip was updated?

@grantfirl I updated them the last time they changed, which was a few weeks ago.

dustinswales commented 1 year ago

March 27th.