search

NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

UFS-dev PR#26 #387

Closed grantfirl closed 1 year ago

grantfirl commented 1 year ago

analogous to https://github.com/NOAA-EMC/fv3atm/pull/606

Note that although these changes allow the SCM to compile and run through the field campaign cases, more work will need to be done in the input and UFS column simulator script to work with a lake point.

grantfirl commented 1 year ago

@mkavulich One more to review for ufs/dev PR#26 ...

grantfirl commented 1 year ago

@grantfirl Sorry about that, approved.

Random question if you get a chance: is there a reason the SCM maintains its own duplicate list of constants instead of using physcons.F90 from ccpp-physics? I've never noticed that's the case before this PR.

I think that we (Dom and others) that physcons.F90 doesn't belong in the CCPP since it is a host-specific file. For some reason, this hasn't been removed from ccpp-physics, but the SCM was coded as-if it doesn't exist.

dustinswales commented 1 year ago

@grantfirl Sorry about that, approved. Random question if you get a chance: is there a reason the SCM maintains its own duplicate list of constants instead of using physcons.F90 from ccpp-physics? I've never noticed that's the case before this PR.

I think that we (Dom and others) that physcons.F90 doesn't belong in the CCPP since it is a host-specific file. For some reason, this hasn't been removed from ccpp-physics, but the SCM was coded as-if it doesn't exist.

I second that emotion.