search

NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Fix input for LSM ICs in UFS replay. Optimize i/o step. #397

Closed dustinswales closed 6 months ago

dustinswales commented 1 year ago

This PR fixes a bug in how the LSM Initial conditions are set for UFS replay. Addresses differences seen in https://github.com/NCAR/ccpp-scm/discussions/369

dustinswales commented 1 year ago

@grantfirl @mkavulich The replay CI test is failing because there was a variable name change from the staged UFS output on the DTC server and what was being used by in #369. I will look into whether we need to update our data, or revert the name change in the code.

XiaSun-Atmos commented 1 year ago

@dustinswales Thanks for preparing this PR. Is this PR ready for me to use, or should I wait until it is committed to the repo? thanks!

dustinswales commented 1 year ago

@XiaSun-Atmos You can use it now if you want, just as long as you're aware that it may change slightly during the review process.

grantfirl commented 6 months ago

@dustinswales I'd like to work on this one. As far as you are aware, this is still needed, right? What kind of testing was done?

XiaSun-Atmos commented 6 months ago

I used this hotfix for the SCM run with active LSM for the CAPE paper.

dustinswales commented 6 months ago

@grantfirl This PR is superseded by #434 (which has this fix and others needed by the replay)