Add more wildcard characters to filenames and add soil color to LSM IC

NCAR / ccpp-scm

CCPP Single Column Model

Other

13 stars 50 forks source link

Add more wildcard characters to filenames and add soil color to LSM IC #419

Closed bluefinweiwei closed 3 months ago

bluefinweiwei commented 7 months ago

1) Add wildcard characters * for various output filenames, e.g., gfs.t00z.atmf0000.nc, gfs.t00z.sfcf0000.nc, oro_C96.mx100.tile1.nc. 2) Add soil color (a new soil property in Noah-MP) to get LSM IC set correctly, otherwise, forcing is not generated due to a crash.

modified: UFS_IC_generator.py
modified: extract_FV3GFS_column_ic.py

dustinswales commented 7 months ago

@bluefinweiwei These changes look fine to me, and the UFS-replay CI test passes, so good job! @grantfirl What's the story with extract_FV3GFS_column_ic.py? Is this a script that is still used?

grantfirl commented 3 months ago

@bluefinweiwei These changes look fine to me, and the UFS-replay CI test passes, so good job! @grantfirl What's the story with extract_FV3GFS_column_ic.py? Is this a script that is still used?

I don't think that this is being used anymore. I think that this was a precursor to UFS_IC_generator.py from Phil Pegion that I slightly modified. I think that we can probably safely remove it from the repo going forward.

grantfirl commented 3 months ago

@bluefinweiwei I'm combining these changes into #459 with others to streamline the open PRs, so I'm closing this. Thanks for the work!

bluefinweiwei commented 3 months ago

Sounds great, thanks!