NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Bug fix for reading sfc fluxes (DEPHYv1) #427

Closed hertneky closed 2 months ago

hertneky commented 5 months ago

Surface fluxes are not read correctly when running the SCM using DEPHYv1 format.

This issue was uncovered from LSM testing from Xia Sun awhile ago. I had mistakenly though that Grant had pulled the fixes into a PR he had open at the time. The issue was uncovered again when @egrell was attempting to run the DEPHY MPACE case.

dustinswales commented 5 months ago

@hertneky Can you add some details to the issue? (e.g. How did you identify the problem?)

hertneky commented 5 months ago

@dustinswales I added more details. Evelyn tested the fixes with MPACE, but I will also test with the ISDAC DEPHY case

mzhangw commented 5 months ago

The issue in coupling to LSM was reported by Dr. Xia Sun from GSL, but not from me.

hertneky commented 5 months ago

@mzhangw You are absolutely right! My mistake!