NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Download climatological aerosol data and fix HR3 nml typo #465

Closed grantfirl closed 4 months ago

grantfirl commented 5 months ago

This PR adds a script in the /contrib directory to download the climatological aerosol data used when the first digit of iaer == 1. It also fixes a typo in the HR3 namelist name and adds iaer=1011 for testing HR3 (there may be other namelist changes forthcoming from @mzhangw )

Note, the script assumes that scm/data/physics_input_data directory already exists, so this should be used after the ./get_all_static_data.sh script.

grantfirl commented 5 months ago

I thought about that too, but this script is adding like 12 GB of data and I don't want to force everyone to download it if they don't need it. Same for Thompson data.

On Wed, May 1, 2024 at 5:34 PM Dustin Swales @.***> wrote:

@.**** approved this pull request.

This looks good to me. Thanks for doing this. However, I wonder if we should just merge the thompson data script and this new aerosol dat fetching script into the getall script?

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-scm/pull/465#pullrequestreview-2034497008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCO5UAVNJD5VIA2JFHCVGDZAFNW3AVCNFSM6AAAAABHCSFHLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZUGQ4TOMBQHA . You are receiving this because you authored the thread.Message ID: @.***>

mzhangw commented 5 months ago

Thanks Grant. I tested the data using TWPICE case with HR3 suite and both iaer = 1011 and 5111. It works well.

Screenshot 2024-05-02 at 10 38 43 AM