NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Update docker container, add Docker auto-build and test, update documentation for building with spack-stack #466

Closed mkavulich closed 4 months ago

mkavulich commented 5 months ago

This PR has several updates that improve SCM documentation, overhaul the docker container, updates new and existing tests, and adds modulefiles for building on MacOS and generic Linux.

Documentation

Documentation for this branch is built here: https://ccpp-scm-mkavulich.readthedocs.io/en/feature-macos_and_docker_build/

This update adds some information about testing to the Repository chapter (though more details should probably be included), and completely overhauls the Quick Start chapter.

Among the changes to the Quick Start chapter are:

Docker

Testing

Other

This PR will resolve #409 and partially resolve #455 (will still need a release container when the time comes)

mkavulich commented 5 months ago

Note: the new job to auto-push the latest container to Dockerhub makes use of repository secrets: I have provided my dockerhub credentials as DOCKERHUB_USERNAME and DOCKERHUB_TOKEN since I can write to the dtcenter organization on Dockerhub. If in the future I am not around, or if I lose access to that Dockerhub org, those secrets will have to be updated.

mkavulich commented 4 months ago

@grantfirl Did you want a chance to review this or can I go ahead and merge it?

grantfirl commented 4 months ago

@mkavulich Can you update to the latest main for good measure before I press the merge button?

mkavulich commented 4 months ago

@grantfirl Rebased my branch on the latest main