NCAR / ccpp-scm

CCPP Single Column Model
Other
13 stars 50 forks source link

Github action version updates: Node.js 16 actions are deprecated #478

Closed scrasmussen closed 1 month ago

scrasmussen commented 1 month ago

Updating Github action versions that the CI is warning are or will be deprecated. Updating checkout to v4, setup-python to v5, cache to v4, upload-artifact to v4, setup-miniconda to v3.

Link to a run with lots of example warning messages that Node.js 16 actions are deprecated..

Tests Performed: the Github actions should run without any warnings.

Requires CCPP-Physics PR#1072

RobertPincus commented 1 month ago

See #480

grantfirl commented 1 month ago

@scrasmussen Can you revert the ccpp/physics submodule update for now? We will bring in the GF fix that'll fix the nvfortran tests from a ufs/dev PR. I don't want to do it out of order.

grantfirl commented 1 month ago

I'll approve once the ccpp-physics submodule pointer change is reverted.

scrasmussen commented 1 month ago

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

scrasmussen commented 1 month ago

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

Sorry was speed reading, looks like your commit fixed it? Will look closer after meeting

grantfirl commented 1 month ago

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

Sorry was speed reading, looks like your commit fixed it? Will look closer after meeting

@scrasmussen Ya, I just pulled in the latest main and pointed to the latest main of ccpp-physics rather than the PR that fixes the openACC bug because it is coming in separately.

grantfirl commented 1 month ago

Combining with https://github.com/NCAR/ccpp-scm/pull/486