Closed jeffdlb closed 4 years ago
@jeffdlb Should our reproduction of this Figure be limited to members 1-30, as in the original, or is there some value to plotting all 40 members?
I think if we're claiming it reproduces we should have it match as closely as possible for this particular notebook. A separate analysis with all 40 members might have some scientific value, however.
That being said, we already show all members and it doesn't change the figure much, do keeping as-is is fine. Bigger issue is the red and black lines.
On Wed, Dec 11, 2019, 10:45 Jeff de La Beaujardière < notifications@github.com wrote:
I think if we're claiming it reproduces we should have it match as closely as possible for this particular notebook. A separate analysis with all 40 members might have some scientific value, however.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/cesm-lens-aws/issues/29?email_source=notifications&email_token=ABF4W4W2744XFTJKSYZALBDQYEYLRA5CNFSM4JYAUNSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUFE3Y#issuecomment-564679279, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF4W4XSZNR5HGSIWKMLW5TQYEYLRANCNFSM4JYAUNSA .
I will try to get to it later today.
If it looks like a non-obvious, multi-hour fix we should discuss first.
I didn't get it completely done, but it looks do-able without too much effort. It's necessary to load the "HIST" experiment, creating three Xarray datasets instead of two. The "HIST" experiment appears to have a single ensemble member with monthly data frequency, which means repeating the patterns we see for creating t_20c_ts, t_ref_ts, etc. with some tweaks.
Here is a binder link that has my current changes. Note that these are still a work in progress, and could contain missing code or typos:
https://aws-uswest2-binder.pangeo.io/v2/gh/bonnland/cesm-lens-aws/fix-figure2?urlpath=lab
I had to create by painstakingly copy-pasting from a notebook running on AWS, which is error-prone.
I will test and fix any bugs tommorrow.
I'm unable to run/debug the notebook on AWS right now. Possibly the load on the Pangeo AWS service is very high, with AGU underway.
@jeffdlb Joe Hamman just added me to the pangeo-data group on GitHub, which gives me access to a persistent AWS environment for modifying the LENS notebooks. Joe thinks you're also a member. Here are the steps I took:
There are a couple of key difference between the original Kay et al. figure 2 and the notebook's reproduction. See attached images. In Notebook version,