NCAR / container-dtc-nwp

End-to-end NWP systems in containers.
https://dtcenter.org/community-code/numerical-weather-prediction-nwp-containers
28 stars 13 forks source link

Fix WPS script to only run ungrib on case date files #51

Closed michelleharrold closed 3 years ago

michelleharrold commented 3 years ago

The WPS script's current functionality is to ungrib all files under the model_data/gfs directory. This causes the ungrib step to be unnecessarily slow. It would be good to fix the functionality to only run on the case-specific files.

fossell commented 3 years ago

I'm not sure I'm understanding this issue. Looking at my recent Sandy test, ungrib only processes from start_date to end_date by the set interval. So for Sandy I only have 3 files that get ungribbed (e.g. FILE:2012-10-27_18, FILE:2012-10-27_21, FILE:2012-10-28_00). All of the data in model_data/gfs does get linked into the wpsprd via link_grib.csh, but I only show 3 fhrs being processed, both in output and according to log file ungrib.log. I will rerun and try to figure out what I'm missing. But could someone explain this issue a bit more? I'm sure Im missing something obvious or just not understanding the issue fully.

fossell commented 3 years ago

Oh, oh! I reread it and understand now. It's about have all of the cases having the data stored in model_data/gfs. Misunderstood the issue, I get what the task is now.

fossell commented 3 years ago

My suggestion for this is probably going to be something like just adding or changing the data directory path to be case specific. e.g. /data/model_data/gfs/sandy or just /data/model_data/sandy for outside container, and editing run_wps accordingly. Would require adding a new env var probably in set_env for case specifics (e.g. "sandy") and also regerating data tarballs to unpack in proper new paths. This ties in to #37 to generalize data source as well. Thoughts?

fossell commented 3 years ago

This will be done in separate PR than 54. For Fix WPS script to only run ungrib on case date files #51: an extra environmental variable (case_name) was added to set_env.ksh of each case where user can indicate the case name, e.g. "sandy". The common run_wps.ksh script was updated to removed the hard coded subdirectory "gfs" from the path pointing to the model input data. Tests performed: Sandy on MacOS with main branch wps_wrf image built locally. Successful through WPS/metgrid steps. TODO: Complete end to test, discuss with group preferred directory organization and naming, Modify/update online tutorial steps for downloading data (e.g. re-tar into preferred directory structure, or add mv commands)

fossell commented 3 years ago

This will need to be done with new release v3.5 since input data will need to be packaged in new directory structure.