Closed michelleharrold closed 2 years ago
@michelleharrold I do not see any draft website content at that link: https://dtcenter.org/nwp-containers-online-tutorial/hurricane-sandy-case-27-oct-2012/visualize-verification-results
Here's a screenshot of the revisions I see listed for that page. I assume I should be reviewing content that's newer than 1/5/22.
How do you want to make the website changes available for me to review?
I'll use this comment to keep a running list of issues/questions.
@JohnHalleyGotway - weird, sorry about the incorrect link to the draft page. Try this page instead.
Pull Request Testing
[x] Describe testing already performed for these changes: This was tested on a MacOS and AWS (using the dtcnwp_basic_image_test AMI as a starting point). It was tested in several permutations: 1) ran sandy end-to-end and loaded into a single database, 2) ran a new customized case (sandy2) end-to-end and loaded into a single database, and 3) used sandy and sandy2 MET output to test new functionality of loading into a single METviewer database and into two separate METviewer databases.
[ ] Recommend testing for the reviewer(s) to perform: @JohnHalleyGotway - can you please test the new functionality for loading MET output from multiple cases into METviewer? I have tested the functionality, but a second set of eyes would be preferred. I have instructions on the commands here; it is a draft, so let me know if you can't see them. The commands work, but I am still working out some of the language and plan on adding a figure to show having multiple cases in a single plot (as well as associated METviewer XML). Also, the example METviewer instructions assume the MET output has already been created.
[ ] Are any changes to the online tutorial required for this PR? These changes were done in conjunction with updating the METviewer customization section on the online tutorial. Customization instructions for loading MET output from multiple cases into METviewer are in draft form and will be published once the PR is approved.
[ ] Will this PR change the output of any of the existing cases? No
[ ] Please complete this pull request review by 18 Feb. 2022.
Pull Request Checklist