Closed michelleharrold closed 2 years ago
@jwolff-ncar - thanks for reviewing. For adding instructions to the website, would this be a good spot? ALternative suggestion, would be here.
Either of those would work. Maybe I like the first option better. Another option - what do you think about adding it prior to running WPS on the case pages?
We could add it before WPS on the case pages; that would work well. Would we list this as an optional step?
Yeah, I think that could work. Just mention it is an optional step to look at the domain if they so choose.
Sounds good! I will add that to the website and then merge and close this issue.
Pull Request Testing
Tests have also been done with using Mercator and Polar Steroegraphic projections. These projection tests provide close but not reproducible results when running with the new Python capability as compared to the NCL capability. Work will be ongoing to fully support Mercator and Polar Steroegraphic projections. As such, these projections are deemed not fully supported.
To run, example command:
The run command assumes PROJ_DIR and CASE_DIR have been set. Additionally, it also assumes you have created the ${CASE_DIR}/pythonprd directory. Output is written to ${CASE_DIR}/pythonprd.
Note: This PR also removes NCL-related materials from the repo, per Issue #62. A quick test was run (sandy) to make sure removing NCL-related materials did not cause any issues; everything worked as expected.
[x] Recommend testing for the reviewer(s) to perform: @jwolff-ncar -- Please test the three supplied cases (sandy, snow, and derecho) to make sure run commands execute appropriately. If time allows, it would also be great to run a non-supplied namelist.wps through the Python capability, but that will require a bit more work (will need to 1: create a new namelist.wps, and 2: also run the NCL script to confirm the Python capability creates the same plot specs as NCL.)
[ ] Are any changes to the online tutorial required for this PR? [Maybe] We currently do not provide an example of how to create a plot of a proposed domain on the website. We could add this example under the customization section.
[ ] Will this PR change the output of any of the existing cases? [No]
[ ] Please complete this pull request review by 15 March 2022.
Pull Request Checklist