NCAR / container-dtc-nwp

End-to-end NWP systems in containers.
https://dtcenter.org/community-code/numerical-weather-prediction-nwp-containers
28 stars 13 forks source link

Feature/issue_27_python - Python capability to plot WRF domain #80

Closed michelleharrold closed 2 years ago

michelleharrold commented 2 years ago

Pull Request Testing

Tests have also been done with using Mercator and Polar Steroegraphic projections. These projection tests provide close but not reproducible results when running with the new Python capability as compared to the NCL capability. Work will be ongoing to fully support Mercator and Polar Steroegraphic projections. As such, these projections are deemed not fully supported.

To run, example command:

docker run --rm -it -e LOCAL_USER_ID=`id -u $USER` \
-v ${PROJ_DIR}/container-dtc-nwp/components/scripts/common:/home/scripts/common \
-v ${PROJ_DIR}/container-dtc-nwp/components/scripts/sandy_20121027:/home/scripts/case \
-v ${PROJ_DIR}/data/shapefiles:/home/data/shapefiles -v ${CASE_DIR}/pythonprd:/home/pythonprd \
--name run-sandy-python dtcenter/python:3.5.1 /home/scripts/common/run_python_domain.ksh

The run command assumes PROJ_DIR and CASE_DIR have been set. Additionally, it also assumes you have created the ${CASE_DIR}/pythonprd directory. Output is written to ${CASE_DIR}/pythonprd.

Note: This PR also removes NCL-related materials from the repo, per Issue #62. A quick test was run (sandy) to make sure removing NCL-related materials did not cause any issues; everything worked as expected.

Pull Request Checklist

michelleharrold commented 2 years ago

@jwolff-ncar - thanks for reviewing. For adding instructions to the website, would this be a good spot? ALternative suggestion, would be here.

jwolff-ncar commented 2 years ago

Either of those would work. Maybe I like the first option better. Another option - what do you think about adding it prior to running WPS on the case pages?

michelleharrold commented 2 years ago

We could add it before WPS on the case pages; that would work well. Would we list this as an optional step?

jwolff-ncar commented 2 years ago

Yeah, I think that could work. Just mention it is an optional step to look at the domain if they so choose.

michelleharrold commented 2 years ago

Sounds good! I will add that to the website and then merge and close this issue.