NCAR / esm-collection-spec

Earth System Model Collection specification
Apache License 2.0
13 stars 7 forks source link

Add catalog_dict examples #25

Closed charlesbluca closed 2 years ago

charlesbluca commented 4 years ago

Adds two implementations of GFDL CM2.6's esm collection, based on our two ideas for handling internal catalog_dicts:

charlesbluca commented 4 years ago

Thanks for the review! I'll commit these changes and do the same with sample-catalog-dict-attribute.json.

m-mohr commented 4 years ago

Great, both files validate now.

charlesbluca commented 4 years ago

In examples/sample-catalog-dict-attribute.json, should "esm.data_column_name" be changed to "esm:data_field"?

m-mohr commented 4 years ago

Hmm, there's no such field in my schema. And also I'm wondering why there's a "esm:catalog". That should be in the assets, I think? Like in the other example...

charlesbluca commented 4 years ago

Originally the intent of my examples was to showcase how a single-file catalog might look if we took either approach we were discussing on call - either each item would be given a key and placed in assets or all items would be enumerated in a JSON dictionary, hence the esm:catalog attribute.

If the schema only supports entries in assets, I'm happy to remove the incorrect example!

m-mohr commented 4 years ago

Maybe we should wait for the written spec and then discuss based on that and the schema. I may not have everything right with the schema, too. But I thought we had discussed to put the esm:catalog parts into assets. Who was the person working on the written spec again? @jhamman?

rabernat commented 4 years ago

Narrative description is here: https://github.com/NCAR/esm-collection-spec/blob/stac/collection-spec/collection-spec.md

andersy005 commented 4 years ago

I am curious about how to specify esm:format and esm:data_field fields

 "esm:data_field": "path",
 "esm:format": "zarr"

for catalogs that are embedded in the JSON file? Where do these fields belong?

m-mohr commented 4 years ago

It seems the self-contained catalogs need a discussion. They are not in the Schema yet, partly described in the documentation and in these examples, but the final behavior seems not clear yet.