search

NCAR / esm-collection-spec

Earth System Model Collection specification
Apache License 2.0
13 stars 7 forks source link

Inconsistency in names #34

Open wachsylon opened 2 years ago

wachsylon commented 2 years ago

Hi,

the aggregations object has a key attribute_name. I suggest to change that to column_name since in all other cases column_name is used (e.g. variable_column_name, format_column_name).

Best, Fabi

wachsylon commented 2 years ago

....aaaandd there is also groupby_attrs which of course could be groupby_column_names. But I start to think that it could also be a solution to do it the other way around?

wachsylon commented 2 years ago

and what about options of the aggregation_object: If that is just xarray kwargs, why not naming it xarray_kwargs?